gravatar 2.0: Fix gravatar, remove twitter and identica #878
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the serendipity_request_url wrapper to fetch the favicon. This follows redirects by defaults and will save maintenance work in the future.
Wavatars being originally a wordpress plugin is under GPL, which means the gravatar plugin has to be as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A thorough update of the gravatar plugin.
Some avatar options were broken. This PR fixes the gravatar option by moving from md5 hashes to the now required sha256. It removes the other two that broke, identica and twitter. In both cases the used APIs do not exist anymore (though for identica it's possible that there are alternatives, if someone wants to maintain that integration again - I just saw no clear solution, but might have missed something).
With sha256 used for gravatar, I also changed all other plugin hashes to use sha256.
The wavatar generator had a slightly newer version, which gets used now. This fixes a PHP 8 compatibility issue. There were some additional PHP 8 fixes throughout the plugin, and that PHP version is now set as required.
Documentation and translations were outdated. This PR fixes the links that explain the various avatar options - apart from favatars, there is nothing online, so this became just text. It also removes the remaining references to MyBlogLog missed in 26c462a, and the now removed services.